Skip to content

Fix snippet ID for new snippet syntax #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Fix snippet ID for new snippet syntax #16789

merged 4 commits into from
Jan 22, 2020

Conversation

pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Jan 22, 2020

Maybe I've used the new syntax not correctly but currently it renders the whole file with the snippets:
image

So, switching to the original syntax, or please correct me if the usage of the new syntax is wrong.
/cc @Youssef1313

Article in consideration:
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/value-types

@Youssef1313
Copy link
Member

@mairaw, I don't know if this is possible. But it would be helpful if the build shows warnings or suggestions when the sample is found, but the particular id is not found.

@BillWagner
Copy link
Member

Overall, this is working correctly now, using the full snippet syntax. Thanks @pkulikov

As @mairaw and @Youssef1313 point out we have some issues that need to be addressed in the new snippet syntax.

This is ready to merge, pending discussions on the snippet syntax resolution. @mairaw Do you know the plan for any changes based on dotnet/dotnet-api-docs#3769 (comment)?

@pkulikov pkulikov changed the title Use original snippet syntax Fix snippet ID for new snippet syntax Jan 22, 2020
@mairaw
Copy link
Contributor

mairaw commented Jan 22, 2020

No @BillWagner, I haven't heard anything back from yet. I'll ping them again.

@pkulikov
Copy link
Contributor Author

@BillWagner @mairaw do you want to merge this as it is, with the full snippet tags, or should I revert to the old snippet syntax?

@BillWagner
Copy link
Member

@pkulikov

do you want to merge this as it is, with the full snippet tags, or should I revert to the old snippet syntax?

Let's revert to the old syntax. Once we see what the plans are for addressing the open issues, we'll have a better idea how to proceed toward the new syntax.

Thanks.

@pkulikov
Copy link
Contributor Author

Let's revert to the old syntax.

@BillWagner that's done.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to :shipit:

Thanks for helping us work through these issues @pkulikov We appreciate it.

@BillWagner BillWagner merged commit d2e3bcf into dotnet:master Jan 22, 2020
@pkulikov pkulikov deleted the patch-1 branch February 28, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants